Official Unofficial Patches Page

Kev

(Administrator) 02-25-2004, 09:31 #1

User title: Project Lead
Member since 11/2002 · 2998 posts · Location: Exeter, UK
Group memberships: Administrators, Developers, Members

Show profile ·

Link to this post

Hi, there are some patches that are submitted that won't make it into psi due to being non-standard compliant, or ugly, whatever.
Also, some patches will take a long time before they make it into cvs if they fiddle with internals.
As such I've started a page managing these patches so people can apply them to local cvs copies if they want the features.
The first two are a couple of patches by Remko to support contact sending, and "Contact is typing" notifications.
Patches Here

Psi Project Leader.
Homepage, including development blog

The Transporter 02-29-2004, 01:16 #2

Member since 02/2004 · 23 posts
Group memberships: Members

Show profile ·

Link to this post

Hi kev,

I register to those forums to reply to your msg.

I was a user of gaim before switching to psi.

I really enjoy psi, no more bug(not yet), no more appearing windows in front of your screen when you work, nice interface and support totally the jabber protocol.
What I dont like inside psi is the slow developpement ... I know guys, I know what it is programming, I know you have a life and I know I could help you to code in it, but I have not enough skills to do it and more, I have a job who takes me alot of time.

I'm looking since the 0.9.1 in the bug tracker if the 'File Transfer' bug have been assigned to someone... nobody... does that means that you are not searching how to do it or what?

Also, kev, why dont u modify your nice patch to include them in the main tree of psi ??
We really need some nice functions like your patch ...

I recently saw in the cvs of gaim that they implemented the 'File Transfert' inside jabber protocol ... I will try it out as soon as gaim 0.76 will be released ... If it works well, I will stay with gaim until psi implement it in the next version ...

I think that's all I had in my head about psi.

Don't take my post for blame, I'm just writing what I think, if you don't like, admin, just delete the post ...
Again psi is a very great program, running 24h/24 and I love it... but the dev is so slow ... ;(

Cya

-pol-

spike (Administrator) 02-29-2004, 03:19 #3

Member since 02/2003 · 1873 posts · Location: Leuven (Belgium)
Group memberships: Administrators, Developers, Members

Show profile ·

Link to this post

Quote by The Transporter on 02-29-2004, 07:16:
I'm looking since the 0.9.1 in the bug tracker if the 'File Transfer' bug

I think your post belongs in the 'General Discussion' forum. I'm surprised people can actually post here.
Anyway, to answer your question: I suppose by 'File Transfer bug' you mean 'File transfer feature' (since there is no file transfer yet, there can't be a bug). If you would have taken a quick look at the forums, you would have noticed that the developers are currently working hard (and almost exclusively?) on implementing it, and it will be included in the next version of Psi.

- Remko

Kev

(Administrator) 02-29-2004, 05:59 #4

User title: Project Lead
Member since 11/2002 · 2998 posts · Location: Exeter, UK
Group memberships: Administrators, Developers, Members

Show profile ·

Link to this post

I'm looking since the 0.9.1 in the bug tracker if the 'File Transfer' bug have been assigned to someone... nobody... does that means that you are not searching how to do it or what?

It's aready coded and in cvs for the most part

Also, kev, why dont u modify your nice patch to include them in the main tree of psi ??
We really need some nice functions like your patch ...

None of the patches there are actually mine yet. The reason they're not in cvs is we try to do fairly exhaustive testing before comitting patches that affect core behaviour. There are also some patches (not there yet) which aren't suitable for inclusion in psi for one reason or another, but we're happy for people to use. I'm sitting on one that makes the chat dialogs lag slightly, but makes them prettier.

I recently saw in the cvs of gaim that they implemented the 'File Transfert' inside jabber protocol ... I will try it out as soon as gaim 0.76 will be released ... If it works well, I will stay with gaim until psi implement it in the next version ...

But you didn't check the psi cvs first? Shame on you.

Again psi is a very great program, running 24h/24 and I love it... but the dev is so slow ... ;(

I think that's quite unfair, the development is often quite fast, but the release plan is slow.

Psi Project Leader.
Homepage, including development blog

The Transporter 02-29-2004, 11:24 #5

Member since 02/2004 · 23 posts
Group memberships: Members

Show profile ·

Link to this post

Quote by Kev on 02-29-2004, 10:59:
I'm looking since the 0.9.1 in the bug tracker if the 'File Transfer' bug have been assigned to someone... nobody... does that means that you are not searching how to do it or what?
It's aready coded and in cvs for the most part

Wow sorry forget what I say.

Quote by Kev on 02-29-2004, 10:59:
Also, kev, why dont u modify your nice patch to include them in the main tree of psi ??
We really need some nice functions like your patch ...
None of the patches there are actually mine yet. The reason they're not in cvs is we try to do fairly exhaustive testing before comitting patches that affect core behaviour. There are also some patches (not there yet) which aren't suitable for inclusion in psi for one reason or another, but we're happy for people to use. I'm sitting on one that makes the chat dialogs lag slightly, but makes them prettier.

Hoo ok

Quote by Kev on 02-29-2004, 10:59:
I recently saw in the cvs of gaim that they implemented the 'File Transfert' inside jabber protocol ... I will try it out as soon as gaim 0.76 will be released ... If it works well, I will stay with gaim until psi implement it in the next version ...
But you didn't check the psi cvs first? Shame on you.

Yeah sorry my bad ... The psi cvs changelog is bookmarked now

Quote by Kev on 02-29-2004, 10:59:
Again psi is a very great program, running 24h/24 and I love it... but the dev is so slow ... ;(
I think that's quite unfair, the development is often quite fast, but the release plan is slow.

Yes that's what I wanted to say. But why the release plan is so slow ??

The Transporter 02-29-2004, 11:25 #6

Member since 02/2004 · 23 posts
Group memberships: Members

Show profile ·

Link to this post

Quote by spike on 02-29-2004, 08:19:

Quote by The Transporter on 02-29-2004, 07:16:
I'm looking since the 0.9.1 in the bug tracker if the 'File Transfer' bug

I think your post belongs in the 'General Discussion' forum. I'm surprised people can actually post here.
Anyway, to answer your question: I suppose by 'File Transfer bug' you mean 'File transfer feature' (since there is no file transfer yet, there can't be a bug). If you would have taken a quick look at the forums, you would have noticed that the developers are currently working hard (and almost exclusively?) on implementing it, and it will be included in the next version of Psi.

Do you think that file transfer trough transports will be avaiable ??

Kev

(Administrator) 02-29-2004, 11:31 #7

User title: Project Lead
Member since 11/2002 · 2998 posts · Location: Exeter, UK
Group memberships: Administrators, Developers, Members

Show profile ·

Link to this post

Releases seem to be quite slow because there are certain points we want to reach before release. 0.9.2 is file transfer for example, so no matter how much goes in, 0.9.2 won't come around until file transfer's done and dusted.
Also, we like to do exhaustive testing so we don't make releases with bugs in.
File transfer through transports is feasible, but I'd be shocked if anyone ever bothered implementing it (transport issue).

Psi Project Leader.
Homepage, including development blog

infiniti (Administrator) 02-29-2004, 14:26 #8

Member since 09/2002 · 1378 posts · Location: California, USA
Group memberships: Administrators, Developers, Members

Show profile ·

Link to this post

Quote by The Transporter on 02-29-2004, 08:24:
Yes that's what I wanted to say. But why the release plan is so slow ??

Psi is good because of this slow release plan. As kev mentioned, there is fairly extensive testing prior to each release, lasting from a minimum of 1 week to maximum a month (or more, I can't remember what our longest was..).

As for the actual development periods, remember that there are only two main client developers. You'll notice that Gaim has lots more, and KDE's Kopete has something like 15. Interestingly, the quality of each project's software is inversely-proportional to the number of developers involved. I'm a firm believer of the old 'too many cooks in the kitchen' saying.

Sometimes projects are so large that they need more developers. I can understand this, but I don't think an IM client falls into the category of a large project. Mozilla is a large project. KDE is a large project. Psi is not a large project. I maintain that we don't need even 5 people to make an IM client. That's just overkill. Maybe a larger group could finish it faster, but it wouldn't be as good.

The only actual 'problem' with Psi development is that the main developers have to find alternate means of financial support (ie, real jobs, etc). There is nothing wrong with the 'minimal developers model' I explained above, unless such developers are only utilizing half of their potential. The solution to this problem is to pay the developers. There are no other solutions (being more liberal about patch acceptance, recuiting more developers, etc, are not solutions, they are workarounds).

-Justin

davux 03-05-2004, 07:20 #9

Member since 02/2004 · 9 posts · Location: Paris, France
Group memberships: Members

Show profile ·

Link to this post

I don't know if I've understood well, but does this mean that roster exchanging won't be available in Psi unless as a patch ? Why don't you find it worth adding to the official release, since the coding work's mostly done ?

Kev

(Administrator) 03-05-2004, 08:25 #10

User title: Project Lead
Member since 11/2002 · 2998 posts · Location: Exeter, UK
Group memberships: Administrators, Developers, Members

Show profile ·

Link to this post

Patches aren't necessarily there because they won't ever be integrated, just that they're not in yet and might not be for a while.
Work on the core hasn't been exactly linear recently as infinit's tidying lots of stuff up rather than just adding more features. Once that's done I suspect he'll look at the two backend-patches and see if they're suitable for inclusion as is, or if they need more work. They're just available on the patches page in the interim

Psi Project Leader.
Homepage, including development blog

Alexiel 03-21-2004, 22:02 #11

Member since 03/2004 · 2 posts
Group memberships: Members

Show profile ·

Link to this post

I hope I'm not bothering anyone by this...but I really like these patches.
Is there any way we could get an updated version which doesn't leave blank history entries and notify with sound, just when someone's composing on either side, for example?
Maybe I'll be able to figure it out on my own, but this seems to be my own real complaint about it. ^_^;

Alexiel 03-22-2004, 02:22 #12

Member since 03/2004 · 2 posts
Group memberships: Members

Show profile ·

Link to this post

Whew...this is hard. I had the incoming things fixed (this is for the Events/Composing patch), but now it's all "unfixed" again (bleh)...
But, I managed to fix it rather simply, though it took a lot of digging to find it all, and this is probably hacky and mostly unwanted, but it looks as if it works exactly. In psiaccount.cpp: PsiAccount.dj_sendMessage replace the line
if( m.type() != "groupchat" && m.xencrypted().isEmpty() && !findGCContact(m.to())) {
with
    if( !(m.containsEvents() && m.body().isEmpty())
      && m.type() != "groupchat"
      && m.xencrypted().isEmpty()
      && !findGCContact(m.to())) {
and
    if(m.type() != "groupchat")
with
    if(!(m.containsEvents() && m.body().isEmpty())
      && m.type() != "groupchat")

then in psiaccount.cpp, PsiAccount.handleEvent move
      if(d->acc.opt_log) {
      // don't log private messages
      if(!findGCContact(e->from()))
      logEvent(e->from(), e);
      }
just after
    if(e->type() == PsiEvent::Message) {
      MessageEvent *me = (MessageEvent *)e;
      const Message &m = me->message();
as well as copy it to just after
      if(m.type() == "error") {
      // FIXME: handle message errors
      //msg.text = QString(tr("<big>[Error Message]</big><br>%1").arg(plain2rich(msg.text)));
      }
    }
    else {
The first one, in the PsiEvent::Message if block, you rewrite the proper 'if' to be
      if(!m.body().isEmpty() && !findGCContact(e->from()))
and then it should work!

Whew...I spent a lot of time figuring that out...someone needs big API cross-linking documentation stuff. :-D Hah.

Kev

(Administrator) 03-22-2004, 07:21 #13

User title: Project Lead
Member since 11/2002 · 2998 posts · Location: Exeter, UK
Group memberships: Administrators, Developers, Members

Show profile ·

Link to this post

I've passed the link back to the patcher, thanks. It's probably best if we keep discussion of the patches off the forums unless justin says otherwise; pm me details of whatever and I'll see it gets back to the patch maintainer

Thanks

Psi Project Leader.
Homepage, including development blog

halr9000 (Administrator) 03-27-2004, 08:29 #14

User title: I work here
Member since 11/2002 · 2253 posts · Location: Atlanta
Group memberships: Administrators, Members

Show profile ·

Link to this post

Quote by The Transporter on 02-29-2004, 02:16:
Don't take my post for blame, I'm just writing what I think, if you don't like, admin, just delete the post ...

You have found a very valid topic of discussion that WILL NOT get deleted. As someone else around here found out recently, we'll let just about anything into the forums except for "an offtopic post intended to cause flames". This post was 1) on topic and 2) not that critical really. Nobody has a problem with what you said.

Hal Rottenberg
Webmaster, Evangelist, Co-conspirator to the Revolution

skazi 05-16-2004, 14:26 #15

Member since 02/2003 · 98 posts · Location: Wroclaw/Poland
Group memberships: Members

Show profile ·

Link to this post

updated patch for msgevents can be found here. I fixed the history bug (not logging empty messages wheather they contain event data or not), and one more bug... "send message" sound was played with every notification message. it should not play now.

PS. Hal, maybe you should move this topic to more proper place??

This post was edited on 05-16-2004, 14:27 by Unknown user.

Announcement